-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swipe tabs #2370
swipe tabs #2370
Conversation
# Conflicts: # DuckDuckGo/MainViewController.swift
# Conflicts: # DuckDuckGo/MainViewController.swift
…bar depending on location
…actor the code a little
# Conflicts: # Core/FeatureFlag.swift
@brindy One issue I'm running into today is a pretty persistent flickering when changing tabs: RPReplay_Final1707260399.2.MP4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the flickering issue I mentioned, this is all behaving well. I found a nasty memory leak, but was able to reproduce it on main so I'll raise it elsewhere - it's not introduced by this PR.
Code changes seem sensible and I've not been able to break anything on any device with various iOS versions. Let's merge it and give it a go internally. Nice work!
Task/Issue URL: https://app.asana.com/0/72649045549333/1205842534063579/f
Tech Design URL:
CC:
Description:
Add swipe tabs functionality.
Steps to test this PR:
Internal User:
Phone:
iPad:
Themes:
OS Version: